Open
Conversation
humitos
approved these changes
Mar 16, 2026
Member
humitos
left a comment
There was a problem hiding this comment.
I like the idea of the refactor and the next steps in particular. I know that we had some issues with get_available_name in the past (see #11505). We need to make sure this is working as expected.
Storage is key in our infra and I'm a little worried here about breaking something here, so I'm requesting review from another dev here as well just to make sure we are not missing anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently:
So, I'm refactoring our storage classes to:
Some other changes:
This is just the start to make sure nothing breaks. After this I want: